Skip to content

Conversation

gtibo
Copy link
Contributor

@gtibo gtibo commented May 7, 2025

What
I changed the behavior of the Encryption Key LineEdit

image

  1. By default, secrets should be hidden, and only displayed if requested by user.

image

  1. A toggle option to display the Encryption Key of the project export windows.

image

  1. The key becomes hidden again when Encrypt Export is deactivated (reactivating it does not reactivate the “show key” toggle).

Why?

  • As a general rule, “secret” strings should not be readable by default.
  • Avoid key leaking by mistake (e.g. visible on screenshots, displayed by mistake, etc.)

@AThousandShips AThousandShips added this to the 4.x milestone May 8, 2025
@gtibo gtibo force-pushed the show-encryption-key branch from 73921e0 to f23807d Compare May 8, 2025 08:36
@gtibo gtibo requested a review from DarkMessiah July 25, 2025 09:06
@gtibo gtibo requested a review from a team as a code owner July 25, 2025 09:08
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs some work, but overall seems fine.

Could use a review from someone more familiar with encryption.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 28, 2025
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to do it as a toggle button after the line edit, instead of a full option on its own line. Similar style to #104742.

@gtibo
Copy link
Contributor Author

gtibo commented Jul 29, 2025

It would be better to do it as a toggle button after the line edit, instead of a full option on its own line. Similar style to #104742.

image image

Done :)

@gtibo gtibo force-pushed the show-encryption-key branch 2 times, most recently from 4f13cb9 to afbd771 Compare July 31, 2025 19:19
@gtibo gtibo closed this Jul 31, 2025
@gtibo gtibo force-pushed the show-encryption-key branch from afbd771 to 00a0512 Compare July 31, 2025 19:29
@gtibo gtibo reopened this Jul 31, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

@gtibo gtibo force-pushed the show-encryption-key branch from 51602cb to e09cb44 Compare August 1, 2025 07:02
@llama-nl
Copy link

@gtibo could you also do this for release and debug password in Android Export or @syntaxerror247 can do something
Screenshot_20250914_220425

@Repiteo Repiteo merged commit 988721c into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants