-
-
Notifications
You must be signed in to change notification settings - Fork 23.3k
Add "Show Encryption Key" toggle #106146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Show Encryption Key" toggle #106146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code needs some work, but overall seems fine.
Could use a review from someone more familiar with encryption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to do it as a toggle button after the line edit, instead of a full option on its own line. Similar style to #104742.
![]() ![]() Done :) |
4f13cb9
to
afbd771
Compare
afbd771
to
00a0512
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Code looks good to me.
51602cb
to
e09cb44
Compare
@gtibo could you also do this for release and debug password in Android Export or @syntaxerror247 can do something |
Thanks! |
What
I changed the behavior of the Encryption Key LineEdit
Why?