Update EditorImportPlugin docs and clarify which methods are required #104740
+62
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.4
|
I believe this PR, at least in part, is not necessary anymore after #107130 . However, despite that PR, the |
|
@Mickeon It is nice to see that there is some progress with a more general solution to this problem. A keyword in the signature is better than these comments. I am going to see if I can add the required keyword to the docs. |
Jojo-1000
force-pushed
the
update-import-plugin-docs
branch
2 times, most recently
from
70bcb32 to
618f5ee
Compare
Jojo-1000
force-pushed
the
update-import-plugin-docs
branch
from
618f5ee to
98beac0
Compare
Repiteo
removed
the
cherrypick:4.4
|
Could you squash your commits? See our pull request guidelines for more information |
Mickeon
approved these changes
Sep 19, 2025
Jojo-1000
force-pushed
the
update-import-plugin-docs
branch
from
98beac0 to
71723f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104519
Add missing methods to the gdscript code examplewas already included in another commitI did not change the C# example because I was not sure how exactly it should look. The changed example is tested and works.
Clarify which virtual methods are required and which are optional, using the same style as inUse required attribute for required virtual methodsVisualShaderNodeCustom