`Resource::get_rid()` is not exposed as a GDExtension virtual method

[DmitriySalnikov]

Godot version

4.x

System information

Windows 10

Issue description

Resource::get_rid() is not exposed as GDExtension virtual method using GDVIRTUAL*.

For me, this makes it a bit difficult to create my own Texture2D and forces me to override the draw_* methods.
This issue has already been discussed here godotengine/godot-cpp#877, but for some reason it was archived.

Steps to reproduce

N/A

Minimal reproduction project

N/A

[AThousandShips]

This is probably because in the bindings get_rid is not virtual, the virtual method is _get_rid but the extensions treats this as a hidden method I believe

It was archived because it was closed by the person who opened it, this is standard practice afik

[DmitriySalnikov]

the virtual method is _get_rid but the extensions treats this as a hidden method I believe

This method simply does not exist, because GDVIRTUAL* was not used, as for example here

It was archived because it was closed by the person who opened it, this is standard practice afik

Yeah, but I didn't understand why that person decided to close it. 🤷‍♂️

[DmitriySalnikov]

I found a message from reduz that it is impossible to use GDVIRTUAL here.

I also added Resource::get_rid() function as core, this should be added manually to Resource too because the binder does not allow me to use GDVIRTUAL for it due to include dependency

I also looked at the implementation of Resource::get_rid and there is a check for the existence of the _get_rid method in the scripts and some kind of get_rid call to GDExtension. But in GDExtension I found only a pointer with a similar name, which is not assigned any value anywhere.

godot/core/io/resource.cpp

Lines 306 to 323 in 37d1dfe

	RID Resource::get_rid() const {
	if (get_script_instance()) {
	Callable::CallError ce;
	RID ret = get_script_instance()->callp(SNAME("_get_rid"), nullptr, 0, ce);
	if (ce.error == Callable::CallError::CALL_OK && ret.is_valid()) {
	return ret;
	}
	}
	if (_get_extension() && _get_extension()->get_rid) {
	RID ret;
	ret.from_uint64(_get_extension()->get_rid(_get_extension_instance()));
	if (ret.is_valid()) {
	return ret;
	}
	}
	return RID();
	}

But if I manually add the get_rid/_get_rid method and even bind it, then nothing works anyway and I still need to manually override the methods for drawing textures.

[raulsntos]

• Fixed by Fix some legacy code #84944