Skip to content

Implement register unexposed classes #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Dec 20, 2022

Because of renaming gdnative to gdextension, I need to remake #951. Otherwise I can't keep 1 commit.

Need #70329.

@Daylily-Zeleen Daylily-Zeleen marked this pull request as ready for review December 20, 2022 03:23
@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner December 20, 2022 03:23
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/register_unexposed_class branch from e76f7cf to 939e6db Compare December 20, 2022 08:17
@Geometror Geometror added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Dec 20, 2022
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/register_unexposed_class branch 2 times, most recently from d1693b1 to bf59f01 Compare July 17, 2023 10:29
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/register_unexposed_class branch from bf59f01 to 21ed03b Compare September 3, 2023 06:02
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/register_unexposed_class branch from 21ed03b to 2d1f852 Compare September 3, 2023 17:00
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As I mentioned over on PR godotengine/godot#70329, I tested this and it's working great for me!

The code looks good as well.

@dsnopek
Copy link
Collaborator

dsnopek commented Sep 11, 2023

Godot PR was just merged! So, merging this one as well :-)

@dsnopek dsnopek merged commit 16ffb27 into godotengine:master Sep 11, 2023
@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/register_unexposed_class branch September 11, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants