Synchronize gdextension_interface.h with Godot #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
topic:gdextension
Calinou
approved these changes
May 17, 2023
|
We should probably add something a little bit more clearer that people should be using the appropriate tag when they are working on an extension for the current stable release of Godot. We should indeed update master here as soon as this file changes on the Godot side. |
dsnopek
force-pushed
the
sync-gdextension-interface
branch
from
7ad0bf3 to
6347ce2
Compare
Some text to that effect was added in #1115 - it's kind of specific to 4.0 vs 4.1, but it's good for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the gdextension_interface.h in godot-cpp doesn't match the gdextension_interface.h in Godot.
These getting out-of-sync was my fault: with all the rebasing I did around godotengine/godot#35813 and godotengine/godot#76406, the version of gdextension_interface.h that ended up getting committed to godot-cpp is somehow missing the changes from godotengine/godot#35813.
But it's an easy fix :-)