Update to load function pointers for GDExtension interface #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
gdextension-interface
branch
3 times, most recently
from
b96f722 to
79b8cdb
Compare
dsnopek
force-pushed
the
gdextension-interface
branch
from
79b8cdb to
bb54c12
Compare
Calinou
added
enhancement
dsnopek
force-pushed
the
gdextension-interface
branch
from
bb54c12 to
a0765e6
Compare
dsnopek
changed the title
dsnopek
force-pushed
the
gdextension-interface
branch
from
a0765e6 to
a5c6ca5
Compare
|
With my latest push, this PR now has everything I wanted to get in there, so I'm taking it out of draft! |
BastiaanOlij
approved these changes
May 13, 2023
|
Discussed at the GDExtension meeting, and approved along with godotengine/godot#76406 |
|
Thanks! |
paddy-exe
added a commit
to paddy-exe/godot-docs
that referenced
this pull request
May 18, 2023
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
paddy-exe
added a commit
to paddy-exe/godot-docs
that referenced
this pull request
May 18, 2023
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
paddy-exe
added a commit
to paddy-exe/godot-docs
that referenced
this pull request
May 19, 2023
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to this Godot PR godotengine/godot#76406
It uses the new GDExtension interface to load function pointers from that PR, however, I did so in the way that would add the fewest changes possible. So, for example, it ends up loading the function pointers into a big struct like it used to. However, similar to OpenGL, I think it'd be nicer if it loaded them into global variables that we could just call, likegdextension_interface_get_godot_version()as opposed tointernal::gde_interface->get_godot_version().Additionally, it adds some code that attempts to prevent loading newer GDExtensions with older versions of Godot
(needs some more extensive testing)Keeping as a draft until we have consensus that the above PR is the right high-level approach, and then I'll spend some time cleaning it upUPDATE: This PR is now ready for review!