Update postinit handling #1211
Open
Update postinit handling #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beicause
force-pushed
the
update-postinit
branch
4 times, most recently
from
ba02ea9 to
0812e49
Compare
|
Thanks!
There are many more changes than these two. Please edit your initial description to elaborate what exactly the PR does and its motivation. Follow-up to #1208. |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1211 |
beicause
force-pushed
the
update-postinit
branch
from
0812e49 to
14d9878
Compare
|
I'm relatively new to gdext. It seems that we can't modify the object itself (e.g. |
`NOTIFICATION_POSTINITIALIZE` will be recevied correctly in godot 4.4 and later
beicause
force-pushed
the
update-postinit
branch
from
14d9878 to
99e092a
Compare
|
Part of that is what I'm looking into in #557. This PR seems to integrate with Godot's own POST_INIT notification. Can you demonstrate what it enables with some code examples? Please edit the initial post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
classdb_construct_object->classdb_construct_object2string_new_with_utf8_chars_and_len->string_new_with_utf8_chars_and_len2After this PR,
NOTIFICATION_POSTINITIALIZEwill be sent afterinit()and can be received correctly inon_notification()in godot 4.4 or later. See alsotest_notificationsin the itest.Partially addresses #557