Update dalamudAsset cleanup to scan for all directories not current or dev#1355
Open
belthesar wants to merge 2 commits intogoatcorp:masterfrom
Open
Update dalamudAsset cleanup to scan for all directories not current or dev#1355belthesar wants to merge 2 commits intogoatcorp:masterfrom
belthesar wants to merge 2 commits intogoatcorp:masterfrom
Conversation
rankynbass
reviewed
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #xl-dev, this change updates the cleanup routine used to clean up old dalamudAsset versions to scan through the entire directory tree instead of the last 30 or so.