Skip to content

error is always nil #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2019
Merged

error is always nil #558

merged 1 commit into from
Dec 24, 2019

Conversation

whatvn
Copy link

@whatvn whatvn commented Dec 18, 2019

Fixes Or Enhances # .

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • The check for error == nil in isUrl check is not necessary because it's alway nil

@go-playground/admins

@deankarn deankarn merged commit ae15ced into go-playground:master Dec 24, 2019
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Merge pull request go-playground#558 from whatvn/master
ca11360 
error is always nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whatvn @deankarn