doc(oneof): mention 'enum' #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course I'm open to changing the wording, I'd just like to mention either "enum" or "enumeration" in here to ease discovery. To add it more smoothly, maybe something like: |
deankarn
approved these changes
Nov 16, 2024
KimNorgaard
pushed a commit
to KimNorgaard/validator
that referenced
this pull request
Feb 25, 2025
## Fixes Or Enhances Mention 'enum' in the documentation for `oneof`. One of our team member spent too much time looking for an 'enum-like' validation tag, only to find out later that `oneof` exists. This PR intends on making the discovery of this validation tag easier. **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Mention 'enum' in the documentation for
oneof. One of our team member spent too much time looking for an 'enum-like' validation tag, only to find out later thatoneofexists. This PR intends on making the discovery of this validation tag easier.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers