-
Notifications
You must be signed in to change notification settings - Fork 1k
replication: Support GTID tag in PreviousGTIDsEvent #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
b2d723a
03ef43c
4a647d0
19d01d1
ea2270a
2ef06a6
944fbdd
c87af9a
3e59511
5599af2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -229,15 +229,59 @@ type PreviousGTIDsEvent struct { | |
GTIDSets string | ||
} | ||
|
||
type GtidFormat int | ||
|
||
const ( | ||
GtidFormatClassic = iota | ||
GtidFormatTagged | ||
) | ||
|
||
func decodeSid(data []byte) (format GtidFormat, sidnr uint64) { | ||
if data[7] == 1 { | ||
format = GtidFormatTagged | ||
} | ||
|
||
if format == GtidFormatTagged { | ||
sid_mask := []byte{0, 255, 255, 255, 255, 255, 255, 0} | ||
|
||
// Apply the mask | ||
for i, _ := range data[:8] { | ||
data[i] &= sid_mask[i] | ||
} | ||
data = append(data, 0) | ||
|
||
// sidnr | ||
sidnr = binary.LittleEndian.Uint64(data[1:]) | ||
return | ||
} | ||
sidnr = binary.LittleEndian.Uint64(data) | ||
return | ||
} | ||
|
||
func (e *PreviousGTIDsEvent) Decode(data []byte) error { | ||
pos := 0 | ||
uuidCount := binary.LittleEndian.Uint16(data[pos : pos+8]) | ||
|
||
gtidinfo := make([]byte, 8) | ||
copy(gtidinfo, data[:8]) | ||
lance6716 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
format, uuidCount := decodeSid(gtidinfo) | ||
pos += 8 | ||
|
||
previousGTIDSets := make([]string, uuidCount) | ||
for i := range previousGTIDSets { | ||
currentSetnr := 0 | ||
for _ = range previousGTIDSets { | ||
dveeden marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uuid := e.decodeUuid(data[pos : pos+16]) | ||
pos += 16 | ||
isTag := false | ||
lance6716 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
var tag string | ||
if format == GtidFormatTagged { | ||
tagLength := int(data[pos]) / 2 | ||
lance6716 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pos += 1 | ||
if tagLength > 0 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can the tag have zero length? please add comments There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
https://dev.mysql.com/doc/dev/mysql-server/latest/classmysql_1_1gtid_1_1Tag.html#details
So it is non-zero if it has a tag. Note the |
||
isTag = true | ||
tag = string(data[pos : pos+tagLength]) | ||
pos += tagLength | ||
} | ||
} | ||
sliceCount := binary.LittleEndian.Uint16(data[pos : pos+8]) | ||
pos += 8 | ||
intervals := make([]string, sliceCount) | ||
|
@@ -254,9 +298,14 @@ func (e *PreviousGTIDsEvent) Decode(data []byte) error { | |
} | ||
intervals[i] = interval | ||
} | ||
previousGTIDSets[i] = fmt.Sprintf("%s:%s", uuid, strings.Join(intervals, ":")) | ||
if isTag { | ||
previousGTIDSets[currentSetnr-1] += fmt.Sprintf(":%s:%s", tag, strings.Join(intervals, ":")) | ||
lance6716 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} else { | ||
previousGTIDSets[currentSetnr] = fmt.Sprintf("%s:%s", uuid, strings.Join(intervals, ":")) | ||
currentSetnr += 1 | ||
} | ||
} | ||
e.GTIDSets = strings.Join(previousGTIDSets, ",") | ||
e.GTIDSets = strings.Join(previousGTIDSets[:currentSetnr], ",") | ||
return nil | ||
} | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.