Why doesn't the `Error` function have the judgment of `l.sink.Enabled(l. level)` like the `Info` function

[chymy]

Why doesn't the Error function have the judgment of l.sink.Enabled(l. level) like the Info function

logr/logr.go

Lines 294 to 302 in f9181c4

	func (l Logger) Error(err error, msg string, keysAndValues ...any) {
	if l.sink == nil {
	return
	}
	if withHelper, ok := l.sink.(CallStackHelperLogSink); ok {
	withHelper.GetCallStackHelper()()
	}
	l.sink.Error(err, msg, keysAndValues...)
	}

which causes logger.V(level).Error level to be invalid no matter what it is set to

[thockin]

Error is always valid on a Logger. Part of the goal of this design was to allow things like:

Caller:

otherpkg.SomeFunc(logger, args...)
chattypkfg.FuncThatLogs(logger.V(2))

In this case otherpkg is well-behaved wrt logs but chattypkg is too verbose, so we are biasing all of it's info logs by 2 verbosity levels. But errors are still errors.

Is it debatable? Yes. But that is why it is this way.