Check error if rows.Next returns false.#365
Merged
nelsam merged 2 commits intogo-gorp:masterfrom Feb 25, 2018
Merged
Conversation
Per https://golang.org/pkg/database/sql/#Rows.Next, > returns true on success, or false if there is no next result row or an error > happened while preparing it. Err should be consulted to distinguish between > the two cases.
Member
|
The build failure looks to be unrelated; I'll do my best to find time to dig in to it in the next week. |
Member
|
I need to stop telling people I'm going to get to something in a timely manner. Looking in to the build failure now. |
Contributor
Author
|
Thanks for merging! Can you update gopkg.in/go-gorp/gorp.v2? |
Member
|
Created a new release. I really just need to add a pipeline configuration to jenkins (at least, until there's a public concourse that I can add gorp pipelines to) to automatically create new releases. I'm too forgetful to be doing this all manually. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://golang.org/pkg/database/sql/#Rows.Next,
Fixes #364.