postgres: Allow for lowercasing quoted fields#360
Merged
nelsam merged 2 commits intogo-gorp:masterfrom Dec 15, 2017
Merged
Conversation
This allows for conditionally reverting the behavior changed 418d928 at runtime, while maintaining the current behavior by default.
Member
|
Can we get a test that would fail without this feature? |
Contributor
Author
|
@nelsam Sure! I went ahead and added unit tests for most of the Postgres dialect to this PR while I was at it. In particular, check out the section starting at 4735379#diff-789f76b9887a0368e5cd3200b57cb6a1R129 for the tests covering this new lowercase field behavior. I'm a little bit confused at the moment because the tests on travis seem to be inconsistently failing, but I can't get them to fail when running locally. |
Member
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for conditionally reverting the behavior changed
418d928 at runtime, while maintaining
the current behavior by default.