Fix SqlTyper

[icholy]

The SqlType type should be returning a driver.Value instead of driver.Valuer

gorp/db.go

Line 326 in 659d466

gotype = reflect.TypeOf(typer.SqlType())

The way to get it working now is to do something like this

type IntValuer int

func (IntValue) Value() (driver.Value, error) {
  return nil, nil
}

type CustomType int

func (CustomType) SqlType() driver.Valuer {
  return IntValuer(0)
}

This will continue working with the proposed change.

[nelsam]

One last request: can we do log.Printf("Deprecation Warning: update your SqlType methods to return a driver.Value") in the logic for legacySqlTyper?

[icholy]

@nelsam done and squashed.

[nelsam]

awesome! I'll merge on the morrow.

…

On Oct 20, 2017 22:20, "Ilia Choly" ***@***.***> wrote: @nelsam <https://github.com/nelsam> done and squashed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#355 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-QBFV6z9fYdDpKb6-2mYXlkDYeNon0ks5suXEMgaJpZM4P-DCw> .

[icholy]

Messed up the rebase, fixed now.

[icholy]

In regards to changing the null types, I think that will break compatibility with sql.Null<Name> types.

[nelsam]

Yeah. We can maybe update our code to be more aware of how those types usually work, make our code more generic instead of checking the type name for everything, but we have no guarantee that it'll work for all use cases.

Back when we were more active, we had plans to separate the database setup logic and make it a bit more explicit, but it's become difficult to put that much time in to gorp for most of us.