Fix creating unique index on non-unique field #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
When having a named unique index on an non-unique column, the migrator will not check, if the index already exists, resulting in
Error 1061 (42000): Duplicate key name 'index_name'
This fix adds the check, as done in the unique column code branch of the function (line 101).
User Case Description
Creating an index on a non-unique column, but not having a unique constraint:
On the first migration, the index is successfully being created.
On the next migration the following error is given, and no
information_schema
check is being performed:After the fix, the check is being performed: