optimize: performance optimization #7526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This PR is for: #7492, doesn't completely solve the problem,, and only optimizes the performance for FieldByName to avoid every for loop
The implementation of #7492 does not completely solve the problem and introduces performance issues
The following is a reprinted comment
After a lot of testing and consideration, I still don't think this PR should be merged.
Firstly, FieldByName performs poorly with large structs, which makes caching fields ineffective and unnecessary.
Secondly, field.ValueOf only addresses one case — the default implementation remains problematic. Additionally, field.ReflectValueOf hasn't been modified at all.
And filed. FindByName does not solve problems similar to the following