Fixed Empty Returning Clause Merge Edge Case #7339
Merged
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This pull request fixes the merging behavior of two
clause.Returningclauses. Specifically, it ensures that if aclause.Returningcontains expressions withoutColumns, it won't be overridden by specific columns during the merge. This addresses an issue caused by the implicit behavior of emptyclause.Returningclauses.Use Case Description
I work with queries involving multiple embedded models, where each model requires different columns to be returned. Some operations need all columns to be returned, while others need a subset.
Currently, the merging strategy overrides an implicit empty
clause.Returningclause with specific columns, making it impossible to implement this mechanism. This fix resolves that limitation, enabling better control over the returned columns in complex query scenarios.