fix: database/sql.Scanner should not retain references #6380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Documentation for
database/sql.Scanner
states thatScan(src)
should not retain (i.e. it should copy) thesrc
argument.This becomes an issue for this test if a driver returns a slice that is invalidated by
rows.Close()
.User Case Description
Copying the slice fixes this test failing with my SQLite driver.