Skip to content

fix:clickhouse error not capture(#6277) #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

201430098137
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

return err if the query exceed single select sql memory limit. #6277

User Case Description

type User struct {
	Name     string
	Age      uint64
	Birthday string
	Account  string
	Company  string
}
func TestGORM(t *testing.T) {

	// append data
	user := User{
		Name:     "ddddddddddddddddddddddddddddddddfsfdsfsd",
		Age:      0,
		Birthday: "dbdfbbbbbbbbbbbbbbbbbbbbbbbbbdfgfdgfdg",
		Account:  "apoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiwe",
		Company:  "apoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiwevvvapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiweapoiorpqwifpofpwiefpiweopfioeifoeifpwifpewifpwifpewifpewifpweifpiwefpiwepfiwpeifpwiefpiwe",
	}
	var users []User = make([]User, 0, 10000)
	for i := 0; i < 10000; i++ {
		users = append(users, user)
	}

	err := DB.CreateInBatches(users, len(users)).Error
	if err != nil {
		t.Errorf("Failed, got error: %v", err)
	}

	//execute will be fail; because exceed clickhouse query memory limit
	//should return err
	var result []*User = make([]*User, 0)
	err = DB.Raw("select * from users limit 10000 settings max_memory_usage = 2;").Scan(&result).Error
	if err == nil {
		t.Errorf("error not capture")
	}
}

@jinzhu jinzhu merged commit f5837de into go-gorm:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants