Skip to content

TestDialectorWithErrorTranslatorSupport fatal message error #6347

@GGXXLL

Description

@GGXXLL

Description

Hi, Maybe the fatal message is error?

t.Fatalf("expected err: %v got err: %v", translatedErr, err)

I think should be

if !errors.Is(err, untranslatedErr) {
	t.Fatalf("expected err: %v got err: %v", untranslatedErr, err)
}

or

if errors.Is(err, translatedErr) {
	t.Fatalf("expected err: %v got err: %v", untranslatedErr, translatedErr)
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions