Skip to content

Fix error logged when repos qs is empty #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2020
Merged

Fix error logged when repos qs is empty #9591

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a62148a
Fix error logged when repos qs is empty
guillep2k Jan 2, 2020
30b71c4
Merge branch 'master' into fix-invalid-log
techknowlogick Jan 2, 2020
e031e71
Update routers/user/home.go
guillep2k Jan 2, 2020
78da590
Merge branch 'master' into fix-invalid-log
techknowlogick Jan 2, 2020
a340c83
Merge branch 'master' into fix-invalid-log
lafriks Jan 3, 2020
3aef6b6
Merge branch 'master' into fix-invalid-log
lafriks Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions routers/user/home.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,21 +389,23 @@ func Issues(ctx *context.Context) {

reposQuery := ctx.Query("repos")
var repoIDs []int64
if issueReposQueryPattern.MatchString(reposQuery) {
// remove "[" and "]" from string
reposQuery = reposQuery[1 : len(reposQuery)-1]
//for each ID (delimiter ",") add to int to repoIDs
for _, rID := range strings.Split(reposQuery, ",") {
// Ensure nonempty string entries
if rID != "" && rID != "0" {
rIDint64, err := strconv.ParseInt(rID, 10, 64)
if err == nil {
repoIDs = append(repoIDs, rIDint64)
if(reposQuery != "") {
if issueReposQueryPattern.MatchString(reposQuery) {
// remove "[" and "]" from string
reposQuery = reposQuery[1 : len(reposQuery)-1]
//for each ID (delimiter ",") add to int to repoIDs
for _, rID := range strings.Split(reposQuery, ",") {
// Ensure nonempty string entries
if rID != "" && rID != "0" {
rIDint64, err := strconv.ParseInt(rID, 10, 64)
if err == nil {
repoIDs = append(repoIDs, rIDint64)
}
}
}
} else {
log.Error("issueReposQueryPattern not match with query")
}
} else {
log.Error("issueReposQueryPattern not match with query")
}

isShowClosed := ctx.Query("state") == "closed"
Expand Down