Skip to content

Correct a language error in reverse proxy doc #9455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 27, 2019
Merged

Correct a language error in reverse proxy doc #9455

merged 4 commits into from
Dec 27, 2019

Conversation

ZephOne
Copy link
Contributor

@ZephOne ZephOne commented Dec 21, 2019

No description provided.

zeripath
zeripath reviewed Dec 21, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2019
6543
6543 approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add your suggested change - but i dont block docs ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #9455 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9455      +/-   ##
==========================================
- Coverage   41.46%   41.45%   -0.02%     
==========================================
  Files         571      571              
  Lines       75250    75250              
==========================================
- Hits        31205    31195      -10     
- Misses      40172    40183      +11     
+ Partials     3873     3872       -1
Impacted Files Coverage Δ
services/pull/check.go 48.59% <0%> (-5.64%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5748755...41601d5. Read the comment docs.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Dec 27, 2019
@lafriks lafriks merged commit 2401779 into go-gitea:master Dec 27, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@ZephOne ZephOne deleted the ZephOne-correct-language-error-in-doc branch January 25, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagasme bagasme bagasme left review comments

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZephOne @codecov-io @lafriks @zeripath @6543 @bagasme @GiteaBot