Skip to content

Don't send notification on pending reviews #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Don't send notification on pending reviews #8943

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f283f4c
Don't send notification on pending reviews
guillep2k Nov 13, 2019
2836ef9
Merge branch 'master' into fix-8942
lunny Nov 13, 2019
485e0b8
Merge branch 'master' into fix-8942
zeripath Nov 13, 2019
acd014a
Merge branch 'master' into fix-8942
zeripath Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion services/pull/review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ func CreateReview(opts models.CreateReviewOptions) (*models.Review, error) {
return nil, err
}

notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)
if opts.Type != models.ReviewTypePending {
notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)
}

return review, nil
}
Expand Down