Skip to content

Fix mirror repository webhooks #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2019
Merged

Fix mirror repository webhooks #7366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
611590b
Fix mirror sync not automatically sending webhook requests
akkowal2 Jul 6, 2019
a1ebb8b
Merge remote-tracking branch 'upstream/master' into fix-mirror-webhooks
akkowal2 Jul 6, 2019
b33fe46
Merge branch 'master' into fix-mirror-webhooks
techknowlogick Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions models/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,11 @@ func mirrorSyncAction(e Engine, opType ActionType, repo *Repository, refName str
}); err != nil {
return fmt.Errorf("notifyWatchers: %v", err)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move these to https://github.com/go-gitea/gitea/blob/master/models/action.go#L943 because it should be with webhook.

defer func() {
go HookQueue.Add(repo.ID)
}()

return nil
}

Expand Down