Fix README symlink resolution in subdirectories like .github#36775
Merged
wxiaoguang merged 6 commits intogo-gitea:mainfrom Mar 1, 2026
Merged
Fix README symlink resolution in subdirectories like .github#36775wxiaoguang merged 6 commits intogo-gitea:mainfrom
wxiaoguang merged 6 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
Member
|
Can you add a test? |
The `findReadmeFileInEntries` function recursively searches for a README file in well-known subdirectories such as `.github/`, `.gitea/`, and `docs/`. However, the recursive call incorrectly passed the original `parentDir` (usually the repo root) instead of the path to the subdirectory. This caused symlinks inside these subdirectories (e.g., `.github/README.md` pointing to `../subdir/README.md`) to be resolved relative to the root of the repository instead of the subdirectory, resulting in "not found" errors and the README failing to render. This change correctly appends the subdirectory name to the `parentDir` when making the recursive call, allowing `git.EntryFollowLinks` to operate from the correct base path and successfully resolve the symlinks.
Contributor
Author
|
Added test |
wxiaoguang
approved these changes
Feb 28, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 28, 2026
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2026
* giteaofficial/main: (21 commits) Enable docker layer caching for `dry-run` and `nightly` container builds (go-gitea#36738) Add admin badge to navbar avatar (go-gitea#36790) WorkflowDispatch api optionally return runid (go-gitea#36706) upgrade minimatch (go-gitea#36760) Add `never` option to `PUBLIC_URL_DETECTION` configuration (go-gitea#36785) Refactor avatar package, support default avatar fallback (go-gitea#36788) Mark unused&immature activitypub as "not implemented" (go-gitea#36789) Add “Copy Source” to markup comment menu (go-gitea#36726) Update Nix flake (go-gitea#36787) Implements OIDC RP-Initiated Logout (go-gitea#36724) Fix README symlink resolution in subdirectories like .github (go-gitea#36775) [skip ci] Updated translations via Crowdin Correct spelling (go-gitea#36783) refactor: replace legacy tw-flex utility classes with flex-text-block/inline (go-gitea#36778) Fix `no-content` message not rendering after comment edit (go-gitea#36733) Fix typos and grammar in English locale (go-gitea#36751) Move Fomantic dropdown CSS to custom module (go-gitea#36530) Use "Enable Gravatar" but not "Disable" (go-gitea#36771) feat: add branch_count to repository API (go-gitea#35351) (go-gitea#36743) Deprecate RenderWithErr (go-gitea#36769) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36774. Made by Gemini. I verified that this resolves the issue for me.