Add validation constraints for repository creation fields#36671
Merged
lunny merged 10 commits intogo-gitea:mainfrom Feb 25, 2026
Merged
Add validation constraints for repository creation fields#36671lunny merged 10 commits intogo-gitea:mainfrom
lunny merged 10 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
Member
|
Other fields like |
Member
Author
Only the |
Member
Author
These restrictions have been added to enforce stricter validation and prevent potential issues or unnecessary problems. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds input validation constraints to repository creation form fields and API options, limiting the size of various string fields to prevent potential issues with excessively long input values.
Changes:
- Added MaxSize validation to License (100), Gitignores (255), IssueLabels (255), Readme (255), and ForkSingleBranch (255) fields
- Added enum validation with In() to ObjectFormatName (sha1, sha256) and TrustModel (default, collaborator, committer, collaboratorcommitter) fields
- Applied validation consistently to both web form structs (CreateRepoForm) and API structs (CreateRepoOption)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/forms/repo_form.go | Added MaxSize and In() validation tags to CreateRepoForm fields for web form validation |
| modules/structs/repo.go | Added MaxSize and In() validation tags to CreateRepoOption fields for API validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Update PR title please to reflect that it's not only license. |
wxiaoguang
reviewed
Feb 19, 2026
wxiaoguang
reviewed
Feb 19, 2026
lunny
changed the title
github-actions
bot
added
the
modifies/api
wxiaoguang
reviewed
Feb 20, 2026
wxiaoguang
reviewed
Feb 20, 2026
Member
|
Maybe add some tests to validate the new limits? Tests could be AI-generated. |
Contributor
|
Unnecessary tests only slow down the tests. Incorrect tests slow down more. |
wxiaoguang
reviewed
Feb 22, 2026
Member
Author
The tests of binding have been added in binding repository. It seems we don't need to have. |
silverwind
approved these changes
Feb 25, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Feb 25, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 25, 2026
…6671) Adds validation constraints to repository creation inputs, enforcing max-length limits for labels/license/readme and enum validation for trust model and object format. Updates both the API option struct and the web form struct to keep validation consistent.
lunny
added a commit
that referenced
this pull request
Feb 25, 2026
…36757) Backport #36671 by @lunny Adds validation constraints to repository creation inputs, enforcing max-length limits for labels/license/readme and enum validation for trust model and object format. Updates both the API option struct and the web form struct to keep validation consistent. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 26, 2026
* giteaofficial/main: Fix release draft access check logic (go-gitea#36720) Change image transparency grid to CSS (go-gitea#36711) Avoid opening new tab when downloading actions logs (go-gitea#36740) Add validation constraints for repository creation fields (go-gitea#36671) Fix SVG height calculation in diff viewer (go-gitea#36748)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 26, 2026
* main: (24 commits) Instance-wide (global) info banner and maintenance mode (go-gitea#36571) Add created_by filter to SearchIssues (go-gitea#36670) Inline and lazy-load EasyMDE CSS, fix border colors (go-gitea#36714) Fix release draft access check logic (go-gitea#36720) Change image transparency grid to CSS (go-gitea#36711) Avoid opening new tab when downloading actions logs (go-gitea#36740) Add validation constraints for repository creation fields (go-gitea#36671) Fix SVG height calculation in diff viewer (go-gitea#36748) Fix path resolving (go-gitea#36734) [skip ci] Updated translations via Crowdin Fix track time list permission check (go-gitea#36662) Fix incorrect setting loading order (go-gitea#36735) Use case-insensitive matching for Git error "Not a valid object name" (go-gitea#36728) feat: Add workflow dependencies visualization (go-gitea#36248) Add keyboard shortcuts for repository file and code search (go-gitea#36416) Refactor text utility classes to Tailwind CSS (go-gitea#36703) Prevent redirect bypasses via backslash-encoded paths (go-gitea#36660) Fix force push time-line commit comments of pull request (go-gitea#36653) Fix get release draft permission check (go-gitea#36659) Move `X_FRAME_OPTIONS` setting from `cors` to `security` section (go-gitea#30256) ... # Conflicts: # web_src/css/base.css # web_src/css/index.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validation constraints to repository creation inputs, enforcing max-length limits for labels/license/readme and enum validation for trust model and object format. Updates both the API option struct and the web form struct to keep validation consistent.