Skip to content

Refactor packages (func name & UI) #34773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Refactor packages (func name & UI) #34773

merged 3 commits into from
Jun 18, 2025

Conversation

wxiaoguang
Copy link
Contributor

  1. Use OpenXxx instead of GetXxx because the returned readers should be correctly closed, and clarify the behaviors of the functions: they increase the download counter
  2. Use packages-content styles instead of issue-content

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jun 18, 2025
@wxiaoguang
Copy link
Contributor Author

image

@wxiaoguang wxiaoguang mentioned this pull request Jun 18, 2025
Merged
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 18, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jun 18, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2025
@lunny lunny enabled auto-merge (squash) June 18, 2025 18:39
@lunny lunny merged commit 8efc4ca into go-gitea:main Jun 18, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2025
@wxiaoguang wxiaoguang deleted the refactor-packages branch June 18, 2025 23:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8f883a1 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade `gopls` to v0.19.0, add `make fix` (go-gitea#34772)
  Refactor packages (func name & UI) (go-gitea#34773)
  Fix remaining issues after `gopls modernize` formatting (go-gitea#34771)
  Fix some package registry problems (go-gitea#34759)
  Fix incorrect cli default values and default command (go-gitea#34765)
  Support annotated tags when using create release API (go-gitea#31840)
  when using rules to delete packages, remove unclean bugs (go-gitea#34632)
  Fix readme path and markdown link paste (go-gitea#34755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot