Skip to content

Improve "lock conversation" UI #34207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Improve "lock conversation" UI #34207

merged 3 commits into from
Apr 15, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #34203

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 15, 2025
@wxiaoguang
Copy link
Contributor Author

image

image

@wxiaoguang wxiaoguang mentioned this pull request Apr 15, 2025
Closed
@wxiaoguang wxiaoguang changed the title Improve "lock converastion" UI Improve "lock conversation" UI Apr 15, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 15, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 15, 2025 14:37
@wxiaoguang wxiaoguang merged commit d2d381f into go-gitea:main Apr 15, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-issue-lock branch April 15, 2025 22:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0149e24 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix two missed null value checks on the wiki page. (go-gitea#34205)
  Improve "lock conversation" UI (go-gitea#34207)
  Mark parent directory as viewed when all files are viewed (go-gitea#33958)
  Restore form inputs on organization create error (go-gitea#34201)
  Align User Details Page Header Layout with Design Specifications (go-gitea#34192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Reason for locking converastion on issue cannot be reset to empty
5 participants
@wxiaoguang @lunny @delvh @hiifong @GiteaBot