Skip to content

Refactor response writer & access logger #33323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

wxiaoguang
Copy link
Contributor

And add comments & tests

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 19, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 19, 2025
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/go Pull requests that update Go code labels Jan 19, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 20, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 20, 2025 06:00
@wxiaoguang wxiaoguang merged commit 6073e2f into go-gitea:main Jan 20, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-access-log branch January 20, 2025 06:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 21, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix incorrect ref commit ID usage (go-gitea#33331)
  Improve sync fork behavior (go-gitea#33319)
  Refactor response writer & access logger (go-gitea#33323)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants