Skip to content

Only rename a user when they should receive a different name #32247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Only rename a user when they should receive a different name #32247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d426866
Fix change user type failed return rename bug
lunny Oct 12, 2024
28d5d51
check rename condition in the service method instead of outside
lunny Oct 12, 2024
92a533f
Merge branch 'main' into lunny/fix_convert_type
GiteaBot Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/web/admin/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func EditUserPost(ctx *context.Context) {
return
}

if form.UserName != "" {
if form.UserName != "" && form.UserName != u.Name {
if err := user_service.RenameUser(ctx, u, form.UserName); err != nil {
switch {
case user_model.IsErrUserIsNotLocal(err):
Expand Down
Loading