Integrate templates into bindata optionally#314
Merged
tboerger merged 14 commits intogo-gitea:masterfrom Dec 6, 2016
tboerger:templates-bindata
Merged
Integrate templates into bindata optionally#314tboerger merged 14 commits intogo-gitea:masterfrom tboerger:templates-bindata
tboerger merged 14 commits intogo-gitea:masterfrom
tboerger:templates-bindata
Conversation
tboerger
added
type/enhancement
Member
|
Why not just use |
tboerger
added
the
lgtm/need 2
Member
Author
|
@lunny as said, it's work in progress. If we want to add the func map into the same package I can do that in the end |
2 tasks
Since we have bundled all required dependencies via the vendoring we don't need to provide these checks anymore. We make sure to have the correct versions with that.
Since the -prefix option of go-bindata seems to be broken I'm forced to rewrite the paths of the templates with sed.
Member
|
It looks like custom templates are not used when building with Tried with |
Member
Author
Looks like that, but nothing we can fix within Gitea as it seems to be an issue of https://github.com/go-macaron/bindata |
Member
Author
|
The mail templates are always overwritable as we do it manually to read the templates. |
Member
|
If I read it correctly TemplateFileSystem allows you to define
an handler, so I guess a custom handler might implement the custom
directory seek.
|
Contributor
|
Not tested but the code: |
tboerger
added
lgtm/need 1
Contributor
|
code LGTM |
tboerger
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created this pull request to get early feedback. To finish this PR I still need to figure out how we can use the embedded templates for the mailer. Looks like the used macaron.TemplateSet doesn't like bindata.
Partially obsoletes #74.