Skip to content

Remove jQuery class from the comment edit history #30186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2024
Merged

Remove jQuery class from the comment edit history #30186

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c944196
Remove jQuery class from the comment edit history
yardenshoham Mar 30, 2024
14383b3
Merge branch 'main' into repo-issue-content-jquery-class
GiteaBot Mar 30, 2024
d723b13
Merge branch 'main' into repo-issue-content-jquery-class
GiteaBot Mar 30, 2024
482cfde
Merge branch 'main' into repo-issue-content-jquery-class
GiteaBot Mar 30, 2024
94a8857
Merge branch 'main' into repo-issue-content-jquery-class
GiteaBot Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions web_src/js/features/repo-issue-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import $ from 'jquery';
import {svg} from '../svg.js';
import {showErrorToast} from '../modules/toast.js';
import {GET, POST} from '../modules/fetch.js';
import {showElem} from '../utils/dom.js';

const {appSubUrl} = window.config;
let i18nTextEdited;
Expand Down Expand Up @@ -73,10 +74,12 @@ function showContentHistoryDetail(issueBaseUrl, commentId, historyId, itemTitleH
const response = await GET(url);
const resp = await response.json();

$dialog.find('.comment-diff-data').removeClass('is-loading').html(resp.diffHtml);
const commentDiffData = $dialog.find('.comment-diff-data')[0];
commentDiffData?.classList.remove('is-loading');
commentDiffData.innerHTML = resp.diffHtml;
// there is only one option "item[data-option-item=delete]", so the dropdown can be entirely shown/hidden.
if (resp.canSoftDelete) {
$dialog.find('.dialog-header-options').removeClass('tw-hidden');
showElem($dialog.find('.dialog-header-options'));
}
} catch (error) {
console.error('Error:', error);
Expand Down