Skip to content

Solving the issue of UI disruption when the review is deleted without refreshing #29951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Solving the issue of UI disruption when the review is deleted without refreshing #29951

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d548b71
fix
HEREYUA Mar 21, 2024
631a8b0
fix
HEREYUA Mar 21, 2024
37e1fe6
fix
HEREYUA Mar 21, 2024
fd6f4c0
fix
HEREYUA Mar 21, 2024
f21c846
fix
HEREYUA Mar 21, 2024
e91fc52
Merge branch 'main' into fix/delete_review_ui
GiteaBot Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion web_src/js/features/repo-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ export function initRepoIssueCommentDelete() {
const response = await POST($this.data('url'));
if (!response.ok) throw new Error('Failed to delete comment');
const $conversationHolder = $this.closest('.conversation-holder');

const $parentTimelineItem = $this.closest('.timeline-item');
const $parentTimelineGroup = $this.closest('.timeline-item-group');
// Check if this was a pending comment.
if ($conversationHolder.find('.pending-label').length) {
const $counter = $('#review-box .review-comments-counter');
Expand All @@ -185,6 +186,13 @@ export function initRepoIssueCommentDelete() {
}
$conversationHolder.remove();
}
// Check if there is no review content, move the avatar upward to avoid blocking the content below.
if (!$parentTimelineItem.find('.conversation-holder').length) {
const $timelineAvatar = $parentTimelineGroup.find('.timeline-avatar').eq(0);
if ($timelineAvatar.hasClass('timeline-avatar-offset')) {
$timelineAvatar.removeClass('timeline-avatar-offset');
}
}
} catch (error) {
console.error(error);
}
Expand Down