Skip to content

Conversation

denyskon
Copy link
Member

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 17, 2024
@denyskon denyskon requested review from 6543 and delvh March 17, 2024 13:10
@denyskon denyskon added this to the 1.22.0 milestone Mar 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2024
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 17, 2024

Could there be some test code in TestTelegramPayload to cover this case?

@wxiaoguang wxiaoguang added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 17, 2024
@denyskon
Copy link
Member Author

@wxiaoguang Added test

@wxiaoguang wxiaoguang enabled auto-merge (squash) March 17, 2024 13:50
@wxiaoguang wxiaoguang disabled auto-merge March 17, 2024 13:50
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 17, 2024 13:51
@wxiaoguang wxiaoguang merged commit 0285b04 into go-gitea:main Mar 17, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2024
@denyskon denyskon deleted the fix-telegram-hook branch March 17, 2024 14:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 19, 2024
* giteaofficial/main:
  Fix missing error check of bufio.Scanner (go-gitea#29882)
  Remove unused error in graceful manager (go-gitea#29871)
  Migrate border and margin classes to Tailwind (go-gitea#29828)
  Only do counting when count_only=true for repo dashboard (go-gitea#29884)
  Editor error message misleading due to re-used key. (go-gitea#29859)
  [skip ci] Updated licenses and gitignores
  move some scripts from 'build' to 'tools' directory, misc refactors (go-gitea#29844)
  Fix missing code in the user profile (go-gitea#29865)
  Upgrade Go 1.22 and upgrade dependency (go-gitea#29869)
  Fix the wrong locale key of searching users (go-gitea#29868)
  fix telegram webhook (go-gitea#29864)
  Fix user id column case (go-gitea#29863)
  Avoid JS error on issue/pr list when logged out (go-gitea#29854)
  Refactor clone-panel styles (go-gitea#29861)
  Simplify README (go-gitea#29827)
  Load citation JS only when needed (go-gitea#29855)
  Fix semantic.json (go-gitea#29860)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 16, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 8, 2024

-> Refactor webhook #31587
-> Use old behavior for telegram webhook #31588 (quick fix for 1.22, use the old behavior)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code topic/webhooks type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegram webhook broken
4 participants