Skip to content

Warn instead of reporting an error when a webhook cannot be found (#26039) #26211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Warn instead of reporting an error when a webhook cannot be found (#26039) #26211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c593bea
Warn instead of reporting an error when a webhook cannot be found (#2…
puni9869 Jul 28, 2023
e70e479
Merge branch 'release/v1.20' into backport-26039-v1.20
GiteaBot Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion services/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package webhook

import (
"context"
"errors"
"fmt"
"strings"

Expand Down Expand Up @@ -111,7 +112,11 @@ func handler(items ...int64) []int64 {
for _, taskID := range items {
task, err := webhook_model.GetHookTaskByID(ctx, taskID)
if err != nil {
log.Error("GetHookTaskByID[%d] failed: %v", taskID, err)
if errors.Is(err, util.ErrNotExist) {
log.Warn("GetHookTaskByID[%d] warn: %v", taskID, err)
} else {
log.Error("GetHookTaskByID[%d] failed: %v", taskID, err)
}
continue
}

Expand Down