Skip to content

Executable check always returns true for windows #20637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Executable check always returns true for windows #20637

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01460b0
Executable check always returns true for windows
eeyrjmr Aug 2, 2022
777d0fc
gofmt tweak
eeyrjmr Aug 2, 2022
13fe78b
Update modules/repository/hooks.go
eeyrjmr Aug 2, 2022
a609ae4
gofmt comment line
eeyrjmr Aug 2, 2022
3604eff
Merge branch 'main' into chkexe_on_windows
lunny Aug 4, 2022
154e7a4
Merge branch 'main' into chkexe_on_windows
lafriks Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/repository/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"fmt"
"os"
"path/filepath"
"runtime"

"code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/modules/setting"
Expand Down Expand Up @@ -153,6 +154,10 @@ func createDelegateHooks(repoPath string) (err error) {
}

func checkExecutable(filename string) bool {
// windows has no concept of a executable bit
if runtime.GOOS == "windows" {
return true
}
fileInfo, err := os.Stat(filename)
if err != nil {
return false
Expand Down