Skip to content

Conversation

@Eekle
Copy link
Contributor

@Eekle Eekle commented May 4, 2022

Fixes #19602.

Before:
image

After:
image

NOTE:

I'm not presently able to build Gitea from source, so I have demo'd this style change by editing theme-arc-green.css in devtools. I hope this is acceptable given the scope of the PR.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 4, 2022
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 4, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2d40a4a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #19604   +/-   ##
=======================================
  Coverage        ?   47.41%           
=======================================
  Files           ?      953           
  Lines           ?   132668           
  Branches        ?        0           
=======================================
  Hits            ?    62908           
  Misses          ?    62180           
  Partials        ?     7580           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40a4a...971dd18. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 4, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 4, 2022
@wxiaoguang wxiaoguang merged commit 9c04da3 into go-gitea:main May 4, 2022
@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 4, 2022

@Eekle if you want to have this fix in 1.16.x, you can send a backport to 1.16 (a new PR for 1.16 branch)

@Eekle
Copy link
Contributor Author

Eekle commented May 4, 2022

@Eekle if you want to have this fix in 1.16.x, you can send a backport to 1.16 (a new PR for 1.16 branch)

Thank you I will!

@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/v1.16 labels May 4, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 4, 2022
* giteaofficial/main:
  Add health check endpoint (go-gitea#18465)
  Only check for non-finished migrating task (go-gitea#19601)
  Make .cs highlighting legible on dark themes. (go-gitea#19604)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"CommentSpecial" highlighting is near invisible in dark mode (arc-green)

6 participants