Skip to content

Fix DELETE request for non-existent public key (#19443) #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2022
Merged

Fix DELETE request for non-existent public key (#19443) #19444

merged 3 commits into from
Apr 20, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 20, 2022

Fix DELETE request for non-existent public key (go-gitea#19443)
3785221 
- Backport go-gitea#19443
  - Add a return for the first "block" of errors, which fixes the double error messages.
  - Add a return for `externallyManaged`.
  - Resolves go-gitea#19398
@Gusted Gusted added this to the 1.16.6 milestone Apr 20, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them labels Apr 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2022
@6543 6543 requested a review from delvh April 20, 2022 18:19
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2022
@zeripath zeripath merged commit 0c7bf68 into go-gitea:release/v1.16 Apr 20, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh Awaiting requested review from delvh

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.16.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @zeripath @6543 @GiteaBot