Skip to content

Bump mermaid from 8.10.1 to 8.13.8 (#18198) #18206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

Bump mermaid from 8.10.1 to 8.13.8 (#18198) #18206

merged 1 commit into from
Jan 7, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 7, 2022

Updates to latest mermaid.

Backport #18198

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198)
b14c89f 
Updates to latest mermaid.

Backport go-gitea#18198

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.15.10 milestone Jan 7, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 7, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2022
@techknowlogick techknowlogick merged commit 2f4f285 into go-gitea:release/v1.15 Jan 7, 2022
@zeripath zeripath deleted the backport-18198-v1.15 branch January 7, 2022 23:02
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Jan 14, 2022
@richmahn richmahn mentioned this pull request Jan 14, 2022
Merged
zeripath pushed a commit that referenced this pull request Jan 14, 2022
@richmahn
Changelog for 1.15.10 (#18274)
a6f9ebf 
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
zeripath pushed a commit to zeripath/gitea that referenced this pull request Jan 14, 2022
@richmahn @zeripath
Changelog for 1.15.10 (go-gitea#18274)
caea4f2 
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
@zeripath zeripath mentioned this pull request Jan 14, 2022
Merged
techknowlogick pushed a commit that referenced this pull request Jan 14, 2022
@zeripath @richmahn
Changelog for 1.15.10 (#18274) (#18276)
2b16ca7 
* Changelog for 1.15.10 (#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Richard Mahn <[email protected]>
@wxiaoguang
Copy link
Contributor

This PR seems to break mermaid .

mermaid can be rendered in 1.15.9, but not 1.15.10

index.js?v=759b74ce43947f5f4c91aeddc3e5bad3:2299 Uncaught (in promise) TypeError: mermaid.initialize is not a function
    at index.js?v=759b74ce43947f5f4c91aeddc3e5bad3:2299:13
    at Generator.next (<anonymous>)
    at fulfilled (index.js?v=759b74ce43947f5f4c91aeddc3e5bad3:2270:24)

This was referenced Jan 24, 2022
Closed
Merged
@silverwind
Copy link
Member

Should have at least tested this once. The exports changed during this version bump, breaking the mermaid rendering entirely.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath @richmahn
Changelog for 1.15.10 (go-gitea#18274) (go-gitea#18276)
2e1a71f 
* Changelog for 1.15.10 (go-gitea#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Richard Mahn <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.15.10
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @wxiaoguang @silverwind @techknowlogick @Gusted @GiteaBot