Skip to content

Fix branch api canPush and canMerge #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2020
Merged

Fix branch api canPush and canMerge #10776

merged 2 commits into from
Mar 21, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 20, 2020

#10767 missed to fix UserCanPush and UserCanMerge, this PR will fix them. It should not be always true even if there is no branch protection. It depends if user login and have permission to write to the code unit.

@lunny lunny added this to the 1.12.0 milestone Mar 20, 2020
@lunny lunny mentioned this pull request Mar 20, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 20, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2020
@techknowlogick techknowlogick merged commit dcaa564 into go-gitea:master Mar 21, 2020
@lunny lunny deleted the lunny/fix_branch_api3 branch March 21, 2020 04:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @guillep2k @techknowlogick @GiteaBot