Webhooks triggered twice

[0x1793d1]

• Gitea version (or commit ref): 1.9.0
• Git version: 2.22.0
• Operating system: Debian Buster / Docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

Hi,

Since 1.9.0, webhooks are triggered twice when committing via the website.

[lunny]

It seems there is one PR fixed that.

[0x1793d1]

You mean #7684?, I saw this PR, but it doesn't seem to work for my case.

[lunny]

No, I mean #7516, but it seems it hasn't been fixed.

[zeripath]

So I think this is because we're now running commits through the git hooks - so the webhook actions in commit repo action might be no longer needed.

@0x1793d1 are you sure that the webhooks you receive are absolutely the same?

[0x1793d1]

@zeripath Yes, they are the same.

Result on try.gitea.io : https://webhook.site/#!/ad98b669-2775-45b5-a98e-164aed79aa48/01e88be5-81b8-4582-9cc9-f72ba6b3a8b3/1

[lunny]

It seems recent version fixed this. But I don't know which PR did that.

[lunny]

I can't reproduce this on one 1.9.0 gitea instance with drone 1.1.0.

[lunny]

@0x1793d1 could you check if you have two webhooks from the same ci server.

[0x1793d1]

@lunny I am using Drone as CI server, and it receive two hooks when I commit via the website. I can reproduce this bug with a dummy webhook on try.gitea.io:

[quantonganh]

I can't reproduce this on one 1.9.0 gitea instance with drone 1.1.0.

I can reproduce this on Gitea 1.9.0 with Drone 1.2.1.

@lunny Please notice that #7726 is a bit different from this: it happened when we merge a PR. #7702 happened when we commit via web interface.