New pull request from last pushed branch 404 error

[stuzer05]

Description

We use issue reference as branch name

and when I pushed my branch, gitea suggested to create new pr, however "#" in the branch name breaks this feature

Also, pushed branches from one repository are shown in another one for some reason

Gitea Version

trunk

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None

[puni9869]

This is related to html encoding, url.PathEscape of # in the url . I can replicate it in my local.

[puni9869]

I need some feedback on above Pr.

[stuzer05]

I need some feedback on above Pr.

Works with the branch name, however these messages are shown for the wrong repo

[puni9869]

I need some feedback on above Pr.

Works with the branch name, however these messages are shown for the wrong repo

I am little bit confused.
Q 1. Do you have repo1 as a repository in your gitea account.
or
Q 2. Do you have repo1 as a branchname in the repo2 repository [the current repository.]

PS: Please share the screenshot of branches list of repo2 repository. I think these are two different Issues.
Let reproduce one by one.

[stuzer05]

I have 2 repos and issue branch in each of them, created from master

[puni9869]

Works with the branch name, however these messages are shown for the wrong repo

Technically branches should be from same repo only.
I have less knowledge on this feature. Is it intentional to show all branches from all repositories.

PS: I have confirmed, github shows only branches which are to beNew Pull Request only from that repository only.

[stuzer05]

I have less knowledge on this feature. Is it intentional to show all branches from all repositories.

This must be a bug, because in the code of those messages there're 2 sql queries WITH repository check. But it works incorrectly

[puni9869]

Fix: #25812

[stuzer05]

Fix: #25812

You didn't include fix for branch names with "#" here