chore: upgrade [email protected] (fusaka devnet 5) #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate GnosisEngineValidatorBuilder comment
dapplion
reviewed
Sep 24, 2025
…te related constants and logic. Adjusted chain value parser to recognize "devnet" as an alias for "fusaka-devnet-5".
debjit-bw
changed the title
dapplion
reviewed
Sep 29, 2025
| // Explicitly set nonce to 0 so revm does not do any nonce checks | ||
| nonce: 0, | ||
| gas_limit: 30_000_000, | ||
| gas_limit: TX_GAS_LIMIT, |
Member
There was a problem hiding this comment.
Double-check the actual gas limit with other clients
dapplion
reviewed
Oct 3, 2025
| use revm_state::{Account, AccountInfo, AccountStatus}; | ||
|
|
||
| // https://eips.ethereum.org/EIPS/eip-7825 | ||
| const TX_GAS_LIMIT: u64 = 30_000_000; |
Member
There was a problem hiding this comment.
Remove this comment and link the gnosis spec. The EIP doesn't mean anything here. You can fix in a future PR if you want
dapplion
approved these changes
Oct 3, 2025
Member
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies and refactors logic to ensure compatibility with newer versions of core libraries, while also improving workflow automation for prerelease branches and Docker image tagging. The most significant changes are the upgrade of the
rethand related crates, modifications to blob parameter handling, and workflow improvements for CI/CD.Dependency Upgrades and Compatibility
reth-related dependencies inCargo.tomlfrom versionv1.5.1tov1.7.0, and upgraded several other core crates (revm,alloy-*,serde_json, etc.) to their latest versions for improved stability and feature support. New dependencies likereth-engine-local,alloy-network, andalloy-rpc-types-ethwere added.src/block.rsandsrc/build.rsto match new APIs, including changes to transaction execution, block assembly, and timestamp handling (e.g., usingsaturating_to()instead ofto()). [1] [2]Blob Parameter Refactoring
blob_base_cost: 0to bothCANCUN_BLOB_PARAMSandPRAGUE_BLOB_PARAMSinsrc/blobs.rsto match updated blob parameter structures. (F64d0f70L6R6, src/blobs.rsR19)src/blobs.rs, relying instead on updated logic from dependencies.Workflow and CI/CD Improvements
.github/workflows/test.ymlto trigger workflows onprerelease-*branches and tag Docker images for these branches, improving prerelease automation. [1] [2] [3]Block Assembly and Execution Refactoring
Block<F::Transaction>toGnosisBlockand updated extra data string to reflect the new version ([email protected]). [1] [2]src/block.rsto simplify and clarify Gnosis-specific handling. [1] [2]These changes collectively modernize the codebase, improve maintainability, and ensure smoother CI/CD for both main and prerelease branches.