chore: bump to reth 1.4.3 #72
Conversation
| BlobScheduleBlobParams { | ||
| cancun: CANCUN_BLOB_PARAMS, | ||
| prague: PRAGUE_BLOB_PARAMS, | ||
| osaka: PRAGUE_BLOB_PARAMS, |
There was a problem hiding this comment.
I assigned the prague blob params here for now,
this entire thing is subject to change as the format is still wip
| let components = |spec: Arc<C::ChainSpec>| { | ||
| ( | ||
| GnosisExecutorProvider::new(spec.clone()), | ||
| GnosisEvmConfig::new(spec.clone()), |
There was a problem hiding this comment.
in 1.4 the ExecutorProvider was unified with EvmConfig
| Commands::ImportEra(_) => unimplemented!(), | ||
| Commands::Download(_) => unimplemented!(), |
There was a problem hiding this comment.
these are new wip commands for era import /pre-merge history expiry
|
|
||
| #[allow(missing_debug_implementations)] // missing revm::Context Debug impl | ||
| pub struct GnosisEvm<DB: Database, I, PRECOMPILE = EthPrecompiles> { | ||
| pub struct GnosisEvm<DB: Database, I, PRECOMPILE = PrecompilesMap> { |
There was a problem hiding this comment.
this is just a different representation of the precompiles
|
|
||
| /// Provides a mutable reference to the EVM inspector. | ||
| pub fn inspector_mut(&mut self) -> &mut I { | ||
| &mut self.inner.0.data.inspector |
There was a problem hiding this comment.
this layer has been flattened
| type Precompiles = PRECOMPILE; | ||
| type Inspector = I; |
There was a problem hiding this comment.
these are additional AT that allow us to access this via the trait directly
src/evm/gnosis_evm.rs
Outdated
| fn validate_against_state_and_deduct_caller( | ||
| &self, | ||
| evm: &mut Self::Evm, | ||
| ) -> Result<(), Self::Error> { | ||
| // TODO: is this equivalent to pre_execution::validate_against_state_and_deduct_caller(evm.ctx()) |
There was a problem hiding this comment.
I believe this replaced deduct_caller but I'm not sure if this here is equivalent
There was a problem hiding this comment.
@rakita how to migrate this from fn deduct_caller
There was a problem hiding this comment.
It merges two function validate_agains_state and deduct_caller
We should call pre_execution::validate_against_state_and_deduct_caller(evm.ctx()) from revm here
And add gnosis specific code after it
reth_gnosis/src/evm/gnosis_evm.rs
Lines 283 to 296 in 5d65422
4 participants
migrates to latest reth 1.4.3
this includes a few breaking changes around the executor/evm type and some internal revm changes.
there's only one thing I'm not entirely sure of of which is the deduct_caller change, which I need to double check.
we also swapped out the EthPrecompiles type to a more flexible
PrecompilesMap