fix - not let rewards contract call fail if the rewards contract hasn't been deployed #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like you need to cherry-pick 4d5b37f on this branch. The rest of fixes already exist in master? |
debjit-bw
force-pushed
the
consistent-client-behaviour
branch
from
7265c54 to
9279904
Compare
Member
Author
|
closing due to conflicting changes with merge targets, recreated in #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skips reward contract call instead of failing. this is in regards to maintaining consistency with other clients who also don't fail if the called contract code is null.