-
Notifications
You must be signed in to change notification settings - Fork 428
fix: compile regx before use #4576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is better ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
… dev/morgan/compile-regx
Because Compile() happens dynamically run-time, it can cause concurrent map writes: gnolang#4568 This PR fixes it by making sure the regexes we use at runtime are already compiled during init. This improves efficiency by not requiring a map lookup each time. --------- Co-authored-by: ltzmaxwell <[email protected]>
Because Compile() happens dynamically run-time, it can cause concurrent map writes: #4568
This PR fixes it by making sure the regexes we use at runtime are already compiled during init.
This improves efficiency by not requiring a map lookup each time.