Skip to content

Conversation

moul
Copy link
Member

@moul moul commented Jul 2, 2025

TODO

  • analysis script to ease the review
  • move packages
  • feedback/review loop
  • fix imports in code etc
  • fix imports and names of packages in docs/

misc/analyze-packages.sh

Start: https://gist.github.com/moul/df4ab7132380e098c447bf64fdfcc860
18th Aug: https://gist.github.com/leohhhn/9ab23e448e8fadeabd43c3d5ad353618 (might be outdated)

misc/analyze-package-changes.sh

Start: https://gist.github.com/moul/2408e90b5cacc15a91f4f7e02b20ec77
18th Aug: https://gist.github.com/leohhhn/fad994d1d9b570e07722fc8a934b4a65 (might be outdated)

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jul 2, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul changed the title chore: add misc/analyze-packages.sh script chore: reorganize examples/ Jul 2, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 2, 2025
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jul 3, 2025
@moul moul force-pushed the dev/moul/examples-reorg branch from 9e23759 to 90672a8 Compare July 3, 2025 13:44
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn
Copy link
Contributor

leohhhn commented Jul 18, 2025

Starting to move things, going along this list: #3959 (comment)

@leohhhn
Copy link
Contributor

leohhhn commented Jul 18, 2025

@moul

grc721 is technically not "defi"; that's why i suggested tokens as an overarching namespace.

@leohhhn leohhhn self-requested a review August 18, 2025 11:57
@leohhhn
Copy link
Contributor

leohhhn commented Aug 18, 2025

Status update: run scripts mentioned in the PR desc to see changes more easily. Need approvals on the namespace moves.

Blockers:

  • Not sure what to do with gnoverse/ namespace
  • Need to fix gno.land & gnovm suite tests

Note: we're changing the valopers path as well so need to communicate to externals.

@leohhhn
Copy link
Contributor

leohhhn commented Aug 18, 2025

Opening up for reviews to get ahead with the process

@leohhhn leohhhn marked this pull request as ready for review August 18, 2025 12:20
@leohhhn leohhhn mentioned this pull request Aug 18, 2025
@leohhhn
Copy link
Contributor

leohhhn commented Aug 20, 2025

Waiting on approvals for the namespace changes before fixing the tests

@Kouteki Kouteki moved this from In Progress to In Review in 🧙‍♂️gno.land core team Aug 22, 2025
# Conflicts:
#	examples/gno.land/r/nt/commondao/z_3_b_filetest.gno
#	examples/gno.land/r/nt/commondao/z_4_b_filetest.gno
#	examples/gno.land/r/nt/commondao/z_8_f_filetest.gno
@leohhhn
Copy link
Contributor

leohhhn commented Aug 22, 2025

TODO: also fix imports and names of packages in docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 📥 Inbox
Status: In Review
Development

Successfully merging this pull request may close these issues.

6 participants