Skip to content

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Jun 24, 2025

Description

Fixing the coin checker so it supports the newest gno-forms PR.

The issue was that the form can only take you to a pre-determined render path within the realm, without the ability to parametrize it. I had to switch to parametrizing via query parameters. Would appreciate if someone can play around a bit.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jun 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: leohhhn/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@leohhhn leohhhn marked this pull request as ready for review June 24, 2025 15:38
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 💯

Just want to make sure we support non-cosmos prefix addresses too 🙏

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jun 24, 2025
@zivkovicmilos
Copy link
Member

We should also consider showing a more clear message for uninitialized addresses, instead of an empty table 👀

@leohhhn
Copy link
Contributor Author

leohhhn commented Jun 24, 2025

@zivkovicmilos

Added the empty balances check for the table. It will just display a message to the user now: 2722085

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixup 🙏

@leohhhn leohhhn merged commit 8945fd4 into gnolang:master Jun 24, 2025
68 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Jun 24, 2025
@leohhhn leohhhn deleted the form/coins branch June 24, 2025 17:58
MikaelVallenet pushed a commit to MikaelVallenet/gno that referenced this pull request Jun 25, 2025
## Description

Fixing the coin checker so it supports the newest gno-forms PR.

The issue was that the form can only take you to a pre-determined render
path within the realm, without the ability to parametrize it. I had to
switch to parametrizing via query parameters. Would appreciate if
someone can play around a bit.
stefann-01 pushed a commit to stefann-01/gno that referenced this pull request Jul 14, 2025
## Description

Fixing the coin checker so it supports the newest gno-forms PR.

The issue was that the form can only take you to a pre-determined render
path within the realm, without the ability to parametrize it. I had to
switch to parametrizing via query parameters. Would appreciate if
someone can play around a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants