Plural: Support ordinals #416
Conversation
| >> **type** Optional | ||
| >> | ||
| >> String `cardinal` (default), or `ordinal`. | ||
|
|
There was a problem hiding this comment.
Please, could you move options above value? Also, replace >> with > only.
|
Hi @tniessen, I left a couple of comments above. Great job so far. |
| @@ -49,7 +74,7 @@ plural( 1 ); | |||
| // > "other" | |||
| ``` | |||
|
|
|||
| For comparison: | |||
| For comparison (cardinals): | |||
There was a problem hiding this comment.
Let's create a similar table for ordinals?
|
I'd like to see a brief definition for both cardinals and ordinals somewhere in the documentation. More examples would also help. |
|
@rxaviers @jzaefferer I pushed a commit a few days ago, awaiting reviews. |
|
|
||
| | | en (English) | ru (Russian) | ar (Arabic) | | ||
| | --- | --- | --- | --- | | ||
| | `plural( 0 )` | `other` | `other` | `other` | |
There was a problem hiding this comment.
All table needs the below change.
- plural( 0 )
+ plural( 0, { type: "ordinal" } )
|
Hi @tniessen, I added a couple of comments. Github doesn't send notifications when new commits are pushed. So, feel free to add a new comment if you have further updates. Thanks so far. |
|
Thank you @tniessen, one last comment. |
| cardinal: cldr.supplemental( "plurals-type-cardinal" ) | ||
| }; | ||
| MakePlural.rules = {}; | ||
| MakePlural.rules[type] = cldr.supplemental( "plurals-type-" + type ); |
There was a problem hiding this comment.
spaces MakePlural.rules[ type ] =
|
@tniessen, no problem. Thanks landed 🎉 |
Fixes #403